feat: silent flag in .air.toml, suppressing all air prints #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will errors still show with this flag enabled? If so, it should be fine imho. Errors should never be suppressed imho. |
|
this library generally uses log.Fatalf() for errors, whereas these changes only affect info and debug logs in runner/util.go and runner/logger.go which produce the lion's share of the logs. shouldn't be anything to worry about as far as errors being suppressed. |
|
@jesses-code-adventures Hi, thanks for adding the silent flag, could you rebase the master and rerun the checks? |
useful if the app being watched has structured outputs that are being piped into subsequent program/s.
jesses-code-adventures
force-pushed
the
silent_config_flag
branch
from
5790a6e
to
9673e01
Compare
|
@cosmtrek i have rebased the master but i think I need maintainer approval to run checks |
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful if the app being watched has structured outputs that are being piped into subsequent program/s.